Re: [PATCH net-next v4] Don't destroy the netdev until the vif is shut down

On Wed, 2013-09-18 at 11:37 +0100, Wei Liu wrote:

On Tue, Sep 17, 2013 at 05:46:08PM +0100, Paul Durrant wrote:

quoted

Without this patch, if a frontend cycles through states Closing
and Closed (which Windows frontends need to do) then the netdev
will be destroyed and requires re-invocation of hotplug scripts
to restore state before the frontend can move to Connected. Thus
when udev is not in use the backend gets stuck in InitWait.

With this patch, the netdev is left alone whilst the backend is
still online and is only de-registered and freed just prior to
destroying the vif (which is also nicely symmetrical with the
netdev allocation and registration being done during probe) so
no re-invocation of hotplug scripts is required.

Signed-off-by: Paul Durrant <redacted>
Cc: David Vrabel <redacted>
Cc: Wei Liu <redacted>
Cc: Ian Campbell <redacted>

Acked-by: Wei Liu <redacted>

yeah, looks good, thanks.

Paul, did you test this with non-Windows frontends too? and do things
like vif hot(un)plug still work?

Ian.