Re: [PATCH net-next] net loopback: Set loopback_dev to NULL when freed
From: David Miller <davem@davemloft.net>
Date: 2013-09-17 23:05:30
From: David Miller <davem@davemloft.net>
Date: 2013-09-17 23:05:30
From: ebiederm@xmission.com (Eric W. Biederman) Date: Mon, 16 Sep 2013 18:52:27 -0700
Eric Dumazet [off-list ref] writes:quoted
On Mon, 2013-09-16 at 21:34 -0400, David Miller wrote:quoted
From: Eric Dumazet <redacted> Date: Mon, 16 Sep 2013 17:50:51 -0700quoted
On Mon, 2013-09-16 at 16:52 -0700, Eric W. Biederman wrote:quoted
It has recently turned up that we have a number of long standing bugs in the network stack cleanup code with use of the loopback device after it has been freed that have not turned up because in most cases the storage allocated to the loopback device is not reused, when those accesses happen. Set looback_dev to NULL to trigger oopses instead of silent data corrupt when we hit this class of bug. Signed-off-by: "Eric W. Biederman" <redacted> ---Acked-by: Eric Dumazet <edumazet@google.com>I'd like to apply this to 'net', any objections?No objections from me.No objects from me I just hadn't seen it as a bug fix, but I guess it sort of is.
Ok, done.