Re: [PATCH 1/1] net: race condition when removing virtual net_device
From: Francesco Ruggeri <hidden>
Date: 2013-09-17 05:12:36
Possibly related (same subject, not in this thread)
- 2013-09-10 · Re: [PATCH 1/1] net: race condition when removing virtual net_device · Francesco Ruggeri <hidden>
- 2013-09-10 · Re: [PATCH 1/1] net: race condition when removing virtual net_device · Stephen Hemminger <stephen@networkplumber.org>
- 2013-09-09 · [PATCH 1/1] net: race condition when removing virtual net_device · Francesco Ruggeri <hidden>
On Mon, Sep 16, 2013 at 5:25 PM, Eric W. Biederman [off-list ref] wrote:
If you could verify that my patch to dev_close solves the ordering issues you were seeing I would appreciate that.
I have not run extensive tests, but your patch fixes the reordering issue I was seeing in dev_close_many. When I destroyed a namespace with only v0 and lo the order was preserved from unregister_netdevice_many to netdev_run_todo. Francesco ====== lo down, v0 down unregister_netdevice_queue: v0 (ns ffff880136bc8000) unregister_netdevice_queue: lo (ns ffff880136bc8000) unregister_netdevice_many: v0 (ns ffff880136bc8000) lo (ns ffff880136bc8000) netdev_run_todo: v0 (ns ffff880136bc8000) lo (ns ffff880136bc8000) ====== lo up, v0 down unregister_netdevice_queue: v0 (ns ffff880037ac8000) unregister_netdevice_queue: lo (ns ffff880037ac8000) unregister_netdevice_many: v0 (ns ffff880037ac8000) lo (ns ffff880037ac8000) netdev_run_todo: v0 (ns ffff880037ac8000) lo (ns ffff880037ac8000) ====== lo down, v0 up unregister_netdevice_queue: v0 (ns ffff880136bc8000) unregister_netdevice_queue: lo (ns ffff880136bc8000) unregister_netdevice_many: v0 (ns ffff880136bc8000) lo (ns ffff880136bc8000) netdev_run_todo: v0 (ns ffff880136bc8000) lo (ns ffff880136bc8000) ====== lo up, v0 up unregister_netdevice_queue: v0 (ns ffff880037ac8000) unregister_netdevice_queue: lo (ns ffff880037ac8000) unregister_netdevice_many: v0 (ns ffff880037ac8000) lo (ns ffff880037ac8000) netdev_run_todo: v0 (ns ffff880037ac8000) lo (ns ffff880037ac8000)