Thread (10 messages) 10 messages, 7 authors, 2013-08-01

Re: [PATCH] checkpatch: Warn when using extern with function prototypes in .h files

From: Arend van Spriel <hidden>
Date: 2013-08-01 13:01:06
Also in: lkml

On 08/01/2013 02:21 PM, David Howells wrote:
Joe Perches [off-list ref] wrote:
quoted
Using the extern keyword on function prototypes is superfluous
visual noise so suggest removing it.

Using extern can cause unnecessary line wrapping at 80 columns
and unnecessarily long multi-line function prototypes.

Suggested-by: Hannes Frederic Sowa <redacted>
Signed-off-by: Joe Perches <joe@perches.com>
Nak.

The "extern" makes it much easier to pick out at a glance.
Really? Grouping function prototypes within the header file is much more 
helpful for spotting them.

Regards,
Arend
Please standardise on there _being_ externs if you must do this.

It's gratuitous change anyway and not worth the churn.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help