Re: [PATCH] checkpatch: Warn when using extern with function prototypes in .h files
From: David Howells <dhowells@redhat.com>
Date: 2013-08-01 12:21:16
Also in:
lkml
From: David Howells <dhowells@redhat.com>
Date: 2013-08-01 12:21:16
Also in:
lkml
Joe Perches [off-list ref] wrote:
Using the extern keyword on function prototypes is superfluous visual noise so suggest removing it. Using extern can cause unnecessary line wrapping at 80 columns and unnecessarily long multi-line function prototypes. Suggested-by: Hannes Frederic Sowa <redacted> Signed-off-by: Joe Perches <joe@perches.com>
Nak. The "extern" makes it much easier to pick out at a glance. Please standardise on there _being_ externs if you must do this. It's gratuitous change anyway and not worth the churn. David