-----Original Message-----
From: Jiri Pirko [mailto:jiri@resnulli.us]
Sent: Tuesday, August 27, 2013 11:06 PM
To: Brown, Aaron F
Cc: Kirsher, Jeffrey T; netdev@vger.kernel.org; davem@davemloft.net;
stephen@networkplumber.org; Narendra_K@Dell.com;
bhutchings@solarflare.com; or.gerlitz@gmail.com; Wyborny, Carolyn; Rose,
Gregory V; vyasevic@redhat.com; amwang@redhat.com;
johannes@sipsolutions.net
Subject: Re: [patch net-next v6 4/4] igb/igbvf: implement
ndo_get_phys_port_id

Wed, Aug 28, 2013 at 04:26:28AM CEST, aaron.f.brown@intel.com wrote:

quoted

Sorry, I was out sick towards the end of last week and playing catch up

for the last few days...  Info inline.

quoted

quoted

From: Jiri Pirko [mailto:jiri@resnulli.us]
Sent: Thursday, August 22, 2013 6:10 AM
To: Kirsher, Jeffrey T
Cc: Brown, Aaron F; netdev@vger.kernel.org; davem@davemloft.net;
stephen@networkplumber.org; Narendra_K@Dell.com;
bhutchings@solarflare.com; or.gerlitz@gmail.com; Wyborny, Carolyn;
Rose, Gregory V; vyasevic@redhat.com; amwang@redhat.com;
johannes@sipsolutions.net
Subject: Re: [patch net-next v6 4/4] igb/igbvf: implement
ndo_get_phys_port_id

Thu, Aug 22, 2013 at 12:39:10PM CEST, jeffrey.t.kirsher@intel.com

wrote:

quoted

quoted

quoted

On Mon, 2013-07-29 at 18:16 +0200, Jiri Pirko wrote:

quoted

igb driver generated random number which will identify physical

port.

quoted

quoted

quoted

quoted

This id is available via ndo_get_phys_port_id directly on igb

netdev.

quoted

quoted

quoted

quoted

Also, id is passed to igbvf using mailbox. After that, it is
available via ndo_get_phys_port_id on igbvf netdev as well.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 drivers/net/ethernet/intel/igb/e1000_mbx.h |  1 +
 drivers/net/ethernet/intel/igb/igb.h       |  3 +++
 drivers/net/ethernet/intel/igb/igb_main.c  | 37
++++++++++++++++++++++++++++-
 drivers/net/ethernet/intel/igbvf/igbvf.h   |  4 ++++
 drivers/net/ethernet/intel/igbvf/mbx.h     |  1 +
 drivers/net/ethernet/intel/igbvf/netdev.c  | 38
++++++++++++++++++++++++++++++
 drivers/net/ethernet/intel/igbvf/vf.c      | 34
++++++++++++++++++++++++++
 drivers/net/ethernet/intel/igbvf/vf.h      |  1 +
 8 files changed, 118 insertions(+), 1 deletion(-)

Jiri-

Validation ran into a couple of issues with this patch.  Here is
what Aaron found when testing this patch...

Interesting. So since igbvf_refresh_ppid() is called from
igbvf_reset() and igbvf_probe(), I believed that is enough. Looks
like perm_addr getting works in similar way. Can you please check if
perm_addr is set correctly in the same time reading phys_port_id gives

-EOPNOTSUPP?

quoted

By perm_addr do you mean the MAC Address of the vf?  Yes, it is set up
(and I can view it vi ip link or sysconfig) when I see the op not
supported message (after I fi vfs via sysfs, before bringing the vf
interface up or reloading igbvf.)

Can you please send me dmesg log from the system you are testing this?

Attached, dmesg dump from a fresh boot to the eopnosupp. I've been using a .config with a whole bunch of debug junk in it and this is putting out tons of kobject messages, I can re-build and send something with less junk if it's pushing anything relevant off the top.

Looking at the code, it looks like whenever mac.ops.reset_hw() (which sets
up mac) is called, igbvf_refresh_ppid() is called as well.

Thanks

quoted

quoted

quoted

Aaron Brown wrote:
I think I have to fail this, it seems to have an issue with
initialization.  When I first create a vf via sysfs the pys_port_id
file is created along with the other sysfs files for the vf, however
an attempt to cat out the value returns " Operation not supported".
At this point the vf is still down, if I bring it up (or simply
unload / reload the igbvf driver) I can then cat the file
successfully and the vf interface phys_port_id matches the
phys_port_id of the pf.  This is testing from bare metal, a console
session showing this behavior
follows:

u1304:[0]/sys> find . -iname phys_port_id
./devices/pci0000:00/0000:00:01.0/0000:07:00.0/net/eth0/phys_port_id
./devices/pci0000:00/0000:00:01.0/0000:07:00.1/net/eth1/phys_port_id
./devices/virtual/net/sit0/phys_port_id
./devices/virtual/net/lo/phys_port_id
u1304:[0]/sys> cat
devices/pci0000:00/0000:00:01.0/0000:07:00.0/net/eth0/phys_port_id
5ece9fbd9cd51546982e15c1f2c11e25
u1304:[0]/sys>

So far so good, now make a few vfs and check for new phys_port_id
sysfs

files.

quoted

u1304:[0]/sys> find . -iname sriov_numvfs
./devices/pci0000:00/0000:00:01.0/0000:07:00.0/sriov_numvfs
./devices/pci0000:00/0000:00:01.0/0000:07:00.1/sriov_numvfs
u1304:[0]/sys> echo 2 >

devices/pci0000:00/0000:00:01.0/0000:07:00.0/sriov_numvfs

quoted

u1304:[0]/sys> find . -iname phys_port_id

./devices/pci0000:00/0000:00:01.0/0000:07:00.0/net/eth0/phys_port_id

quoted

./devices/pci0000:00/0000:00:01.0/0000:07:00.1/net/eth1/phys_port_id
./devices/pci0000:00/0000:00:01.0/0000:07:10.0/net/eth2/phys_port_id
./devices/pci0000:00/0000:00:01.0/0000:07:10.2/net/eth3/phys_port_id
./devices/virtual/net/sit0/phys_port_id
./devices/virtual/net/lo/phys_port_id
u1304:[0]/sys>

The first vf is eth2, attempt to cat out it's phys_port_id

u1304:[0]/sys> cat
./devices/pci0000:00/0000:00:01.0/0000:07:10.0/net/eth2/phys_port_id
cat:
./devices/pci0000:00/0000:00:01.0/0000:07:10.0/net/eth2/phys_port_id:
Operation not supported u1304:[0]/sys>

But, if I bring the interface up (or unload / load the igbvf driver)
I

then am able to cat the phys_port_id of the vf and it matches the
phys_port_id of the physical interface.

quoted

u1304:[0]/sys> ifconfig eth2 u1304-2 u1304:[0]/sys> cat
./devices/pci0000:00/0000:00:01.0/0000:07:10.0/net/eth2/phys_port_id
5ece9fbd9cd51546982e15c1f2c11e25
u1304:[0]/sys>