Re: [PATCH 0/3] net: propagate dynamic needed_headroom/tailroom changes

Tue, Aug 20, 2013 at 04:24:37PM CEST, f.fainelli@gmail.com wrote:

2013/8/20 Jiri Pirko [off-list ref]:

quoted

Tue, Aug 20, 2013 at 02:45:49PM CEST, f.fainelli@gmail.com wrote:

quoted

Hi all,

This patchset aims at allowing dynamically changing a given device
needed_headroom/tailroom space and propagating such events to stacked
devices such as bridges and vlans.

You should also add support for other stacked devices, like bonding,
team, macvlan, ovs-datapath, etc.

Ok, will take a look at these.

quoted

quoted

Unless callers use the new helpers (dev_set_headroom/dev_set_tailroom)
there is no functional change introduced.

I tested this with an out of tree Ethernet driver with both VLANs and
bridges and the need for a 64-byte headroom to insert a transmit
status descriptor in front of a SKB.

Would be nice to add at least one driver which would use your new api.

cxgb, niu, ps3_gelic_net and gianfar could probably directly benefit
from this change.

Great, please add use of your new api to one of these and add that patch
to your set. Thanks!

Thanks for your feedback!
--
Florian