RE: [PATCH net v5 0/5] bnx2x: fixes

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-
owner@vger.kernel.org] On Behalf Of Benjamin Poirier
Sent: Tuesday, August 13, 2013 5:07 PM
To: Ariel Elior
Cc: Dmitry Kravkov; davem@davemloft.net; netdev@vger.kernel.org; Eilon
Greenstein
Subject: Re: [PATCH net v5 0/5] bnx2x: fixes

On 2013/08/13 12:38, Ariel Elior wrote:

quoted

quoted

I'm confused. Wasn't "[PATCH net v4 1/6] bnx2x: properly initialize
statistic counters" supposed to fix a race condition? According to
earlier communication with Ariel:
	In this issue a race condition at driver startup causes a second
	statistics query to be sent before the first one completes,
	resulting in a firmware assert and a stuck chip. A patch was
	sent upstream fixing this:
	http://patchwork.ozlabs.org/patch/264810/

As I explicitly mentioned in the communique which you quoted above,

the patch was sent but not yet accepted.

quoted

This is precisely the upstream process - patches are being sent, reviewed

and sometimes rejected and revised.

quoted

If you have further questions please address them to me - the technical

forum is no place for this kind of discussion.

quoted

Thanks,
Ariel

It's a technical question about a patch which was sent upstream. Where
should the discussion happen if not upstream?

Let me rephrase my question:

I'm confused. I thought that "[PATCH net v4 1/6] bnx2x: properly initialize
statistic counters" was meant to fix a race condition at driver startup which
causes a second statistics query to be sent before the first one completes,
resulting in a firmware assert and a stuck chip. Am I mistaken and there is no
such race condition, or is it addressed by the other patches in this series?

There is such condition, but it's not caused by wrongly initialized counted -
the initialization done in a correct way. Patch "[PATCH net v5 1/5] bnx2x: protect
different statistics flows"  - prevents from two outstanding queries to be sent
simultaneously.

Thanks
Dmitry