Re: [PATCH net v5 0/5] bnx2x: fixes
flat view
From: Benjamin Poirier <hidden>
Date: 2013-08-13 12:30:57
On 2013/08/13 02:24, Dmitry Kravkov wrote:
Hello Dave Please consider applying the series of bnx2x fixes to net: * statistics may cause FW assert * missing fairness configuration in DCB flow * memory leak in sriov related part * Illegal PTE access * Pagefault crash in shutdown flow with cnic v1->v2 * fixed sparse error pointed by Joe Perches * added missing signed-off from Sergei Shtylyov v2->v3 * added missing signed-off from Sergei Shtylyov * fixed formatting from Sergei Shtylyov v3->v4 * patch 1/6: fixed declaration order * patch 2/6 replaced with: protect flows using set_bit constraints v4->v5 * patch 2/6: replace proprietary locking with semaphore * droped 1/6: since adds redundant code from Benjamin Poirier
I'm confused. Wasn't "[PATCH net v4 1/6] bnx2x: properly initialize statistic counters" supposed to fix a race condition? According to earlier communication with Ariel: In this issue a race condition at driver startup causes a second statistics query to be sent before the first one completes, resulting in a firmware assert and a stuck chip. A patch was sent upstream fixing this: http://patchwork.ozlabs.org/patch/264810/