Thread (12 messages) flat view 12 messages, 3 authors, 2013-08-02

Re: minimum ICMPv6 message size vs. RPL's DIS

From: Werner Almesberger <hidden>
Date: 2013-08-02 04:53:23

David Miller wrote:
FWIW I think this is a safe change.
Thanks !

Regarding the change to icmpv6.h, I found that the introduction
of the otherwise very nice and tidy "struct icmp6hdr_head" creates
a conflict with net/bridge/br_multicast.c:br_multicast_ipv6_rcv
which has a variable called "icmp6_type".

While it would be easy enough to rename that variable, this makes
me wonder if the change isn't too intrusive after all, I think
I'd rather go with my original idea and just change the size to 4,
with a comment why and what this is.

I'll post the patches in a bit.

- Werner
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help