Re: [PATCH] 9p: client: remove unused code and any reference to "cancelled" function
From: Andi Shyti <hidden>
Date: 2013-07-25 08:56:19
Also in:
lkml
From: Andi Shyti <hidden>
Date: 2013-07-25 08:56:19
Also in:
lkml
Hi David, On Thu, Jul 25, 2013 at 10:54:24AM +0200, Andi Shyti wrote:
This patch reverts commit 80b45261a0b263536b043c5ccfc4ba4fc27c2acc which was implementing a 'cancelled' functionality to notify that a cancelled request will not be replied. This implementation was not used anywhere and therefore removed.
did you mean this?
- spin_lock(&c->lock);
if (oldreq->status == REQ_STATUS_FLSH) {
+ spin_lock(&c->lock);
list_del(&oldreq->req_list);
spin_unlock(&c->lock);
- if (c->trans_mod->cancelled)
- c->trans_mod->cancelled(c, req);I just put the spin_lock inside the if statement, so that it locks only if the statement it's true. Andi