Re: [PATCH] net: trans_rdma: remove unused function
From: Paul Bolle <hidden>
Date: 2013-07-24 23:09:50
Also in:
lkml
From: Paul Bolle <hidden>
Date: 2013-07-24 23:09:50
Also in:
lkml
On Wed, 2013-07-24 at 15:46 -0700, David Miller wrote:
From: Andi Shyti <redacted>quoted
This patch gets rid of the following warning: net/9p/trans_rdma.c:594:12: warning: ‘rdma_cancelled’ defined but not used [-Wunused-function] static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req) The rdma_cancelled function is not called anywhere in the kernel Signed-off-by: Andi Shyti <redacted>Applied to net-next, thanks.
After this patch one might as well revert the rest of commit
80b45261a0b2 ("9P: Add cancelled() to the transport functions.") too. It
seems the entire cancelled callback stuff is now pointless.
As I already asked in https://lkml.org/lkml/2013/7/15/87 : did that
commit "forget to actually hook up rdma_cancelled() into
p9_rdma_trans()?". It does look so to me.
Paul Bolle