Re: [PATCH v2 2/2] fib_rules: add .suppress operation
From: David Miller <davem@davemloft.net>
Date: 2013-07-30 07:03:07
From: Stefan Tomanek <redacted> Date: Tue, 30 Jul 2013 08:53:17 +0200
quoted hunk ↗ jump to hunk
@@ -101,6 +101,17 @@ errout: return err; } +static bool fib4_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) {
...
quoted hunk ↗ jump to hunk
@@ -119,6 +119,18 @@ out: return err; } +static bool fib6_rule_suppress(struct fib_rule *rule, struct fib_lookup_arg *arg) { + struct rt6_info *rt = (struct rt6_info *) arg->result; + /* + * do not accept result if the route does + * not meet the required prefix length + */
Please format this stuff correctly.
Functions are declared like this:
static type NAME(TYPE ARG1, TYPE ARG2)
{
}
You don't put the openning curly brace at the end of the line with the
closing parenthesis of the argument list.
Next, comments are to be formatted:
/* Like
* this.
*/
Thanks.