On Thu, Jul 25, 2013 at 06:29:32PM +0200, Stefan Tomanek wrote:

Dies schrieb Hannes Frederic Sowa (hannes@stressinduktion.org):

quoted

I would try to factor the prefixlen_min check out into a
e.g. fib4_rule_constrain function for which a new field in fib_rules_ops
needs to be created as callback. Also it would be nice to have IPv6
support, too. ;)

I was working on my patchset again and considered your suggestion; however I'm
not sure whether factoring out the constraints into a separate function is
actually that useful, since they are only called from one specific location for
each protocol; can you think of another useful application?

I don't have a strong opinion on that but I do find that it does better fit into
the design of fib_rules and will be easier to extend in future IMHO.

I however did like the idea of adding IPv6 support, so I did -
I'll post the new patch later on.

Cool, thanks.

Greetings,

  Hannes