Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton()
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2013-06-27 21:51:24
Also in:
lkml
On Thu, 27 Jun 2013 14:43:15 +0800 Cong Wang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Cong Wang <redacted> --- include/net/inet_addr.h | 20 ++++++++++++++++++++ net/core/netpoll.c | 24 ++---------------------- 2 files changed, 22 insertions(+), 22 deletions(-)diff --git a/include/net/inet_addr.h b/include/net/inet_addr.h index 66a16fe..1379287 100644 --- a/include/net/inet_addr.h +++ b/include/net/inet_addr.h@@ -4,6 +4,7 @@ #include <linux/in.h> #include <linux/in6.h> #include <linux/socket.h> +#include <linux/inet.h> #include <net/addrconf.h> union inet_addr {@@ -59,4 +60,23 @@ static inline bool inet_addr_multicast(const union inet_addr *ipa) } #endif +static inline int inet_pton(const char *str, union inet_addr *addr) +{
A couple of comments:
1. No reason for this to be inline
2. If function has same name as userspace it must have same arguments
and return value. Either:
a. rename it to kinet_pton or some other name
b. make it work the same.