Re: [Patch net-next v2] gre: fix a regression in ioctl
From: Cong Wang <hidden>
Date: 2013-06-29 03:55:47
From: Cong Wang <hidden>
Date: 2013-06-29 03:55:47
On Sat, 2013-06-29 at 11:33 +0800, Cong Wang wrote:
BTW, ipip has the same bug... I will send a patch for ipip too.
Pravin,
Any reason to add the following check for ipip?
if (p.i_key || p.o_key || p.i_flags || p.o_flags)
return -EINVAL;
It seems the old code doesn't have this check, you added it in commit
fd58156e456d9f68fe04486be378d0bc93641532 (IPIP: Use ip-tunneling code.).
This breaks the API?