On Fri, 2013-06-28 at 20:28 -0700, Pravin Shelar wrote:

On Fri, Jun 28, 2013 at 7:24 PM, Cong Wang [off-list ref] wrote:

quoted

From: Cong Wang <redacted>

When testing GRE tunnel, I got:

 # ip tunnel show
 get tunnel gre0 failed: Invalid argument
 get tunnel gre1 failed: Invalid argument

This is a regression introduced by commit c54419321455631079c7d
("GRE: Refactor GRE tunneling code.") because previously we
only check the parameters for SIOCADDTUNNEL and SIOCCHGTUNNEL,
after that commit, the check is moved for all commands.

right, that API got changed. But these checks can not be added to
generic ip_tunnel layer, which is also used by other tunnel modules.
Can you keep that check in ip_gre module but do it only for add and
del tunnel commands?

Yeah.

BTW, ipip has the same bug... I will send a patch for ipip too.