Thread (16 messages) flat view 16 messages, 4 authors, 2013-06-18

Re: [PATCH net-next 4/5] pxa168_eth: convert skb->end into skb_end_pointer(skb)

From: David Miller <davem@davemloft.net>
Date: 2013-06-18 00:13:28

From: Simon Horman <horms@verge.net.au>
Date: Mon, 17 Jun 2013 11:01:50 +0900
On Fri, Jun 14, 2013 at 05:58:34PM +0900, Isaku Yamahata wrote:
quoted
The change set of 4305b541, "[SK_BUFF]: Convert skb->end to sk_buff_data_t"
converted skb->end from pointer type to sk_buff_data_t.
The pointed value should be accessed via skb_end_pointer().

Since arm arch doesn't define NET_SKBUFF_DATA_USES_OFFSET,
skb->end is effectively pointer. So it doesn't cause a real problem.
But this patch is good for consistency.

Found by inspection. Compile tested only.

Cc: Simon Horman <horms@verge.net.au>
Signed-off-by: Isaku Yamahata <redacted>
Reviewed-by: Simon Horman <horms@verge.net.au>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help