Thread (16 messages) 16 messages, 4 authors, 2013-06-18

Re: [PATCH net-next 1/5] net, atm/ambassader: convert skb->tail into skb_tail_pointer(skb)

From: Simon Horman <horms@verge.net.au>
Date: 2013-06-17 02:00:07

On Fri, Jun 14, 2013 at 05:58:31PM +0900, Isaku Yamahata wrote:
The change set of 27a884dc, "[SK_BUFF]: Convert skb->tail to sk_buff_data_t"
converted skb->tail from pointer into sk_buff_data_t. It missed skb->tail
in drivers/atm/ambassador.c.
This patch converts skb->tail into skb_tail_pointer(skb).

Found by inspection. Compile tested only.

Cc: Simon Horman <horms@verge.net.au>
Cc: Chas Williams <redacted>
Signed-off-by: Isaku Yamahata <redacted>
Reviewed-by: Simon Horman <horms@verge.net.au>
quoted hunk ↗ jump to hunk
---
 drivers/atm/ambassador.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 77a7480..62a7607 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -1403,7 +1403,7 @@ static void amb_free_rx_skb (struct atm_vcc * atm_vcc, struct sk_buff * skb) {
   rx.host_address = cpu_to_be32 (virt_to_bus (skb->data));
   
   skb->data = skb->head;
-  skb->tail = skb->head;
+  skb_reset_tail_pointer(skb);
   skb->len = 0;
   
   if (!rx_give (dev, &rx, pool)) {
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help