-----Original Message-----
From: Richard Genoud [mailto:richard.genoud@gmail.com]
Sent: Thursday, May 23, 2013 4:44 AM
To: Haiyang Zhang
Cc: davem@davemloft.net; netdev@vger.kernel.org; olaf@aepfle.de;
jasowang@redhat.com; linux-kernel@vger.kernel.org;
devel@linuxdriverproject.org
Subject: Re: [PATCH net, 1/2] hyperv: Fix a kernel warning from
netvsc_linkstatus_callback()

2013/4/5 Haiyang Zhang [off-list ref]:

quoted

The warning about local_bh_enable inside IRQ happens when
disconnecting a virtual NIC.

The reason for the warning is -- netif_tx_disable() is called when the
NIC is disconnected. And it's called within irq context.
netif_tx_disable() calls
local_bh_enable() which displays warning if in irq.

The fix is to remove the unnecessary netif_tx_disable & wake_queue()
in the netvsc_linkstatus_callback().

Reported-by: Richard Genoud <redacted>
Tested-by: Long Li <longli@microsoft.com>
Tested-by: Richard Genoud <redacted>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>

---
 drivers/net/hyperv/netvsc_drv.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hyperv/netvsc_drv.c

b/drivers/net/hyperv/netvsc_drv.c index 5f85205..8341b62 100644

--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c

@@ -241,13 +241,11 @@ void netvsc_linkstatus_callback(struct hv_device

*device_obj,

        if (status == 1) {
                netif_carrier_on(net);
-               netif_wake_queue(net);
                ndev_ctx = netdev_priv(net);
                schedule_delayed_work(&ndev_ctx->dwork, 0);
                schedule_delayed_work(&ndev_ctx->dwork,

msecs_to_jiffies(20));

quoted

        } else {
                netif_carrier_off(net);
-               netif_tx_disable(net);
        }
 }

--
1.7.4.1

This should also go to the stable tree, shouldn't it ?
At least 3.8, 3.7 and 3.4 (the 3.2 version is different, and it's in staging. (at not
used by distros anyway))

Cc: stable <stable@kernel.org>

I agree. Adding stable@kernel.org to Cc list.

Thanks,
- Haiyang