Thread (8 messages) 8 messages, 5 authors, 2013-05-28

Re: [PATCH net,1/2] hyperv: Fix a kernel warning from netvsc_linkstatus_callback()

From: David Miller <davem@davemloft.net>
Date: 2013-04-08 16:16:17
Also in: lkml

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri,  5 Apr 2013 14:44:39 -0700
The warning about local_bh_enable inside IRQ happens when disconnecting a
virtual NIC.

The reason for the warning is -- netif_tx_disable() is called when the NIC
is disconnected. And it's called within irq context. netif_tx_disable() calls
local_bh_enable() which displays warning if in irq.

The fix is to remove the unnecessary netif_tx_disable & wake_queue() in the
netvsc_linkstatus_callback().

Reported-by: Richard Genoud <redacted>
Tested-by: Long Li <longli@microsoft.com>
Tested-by: Richard Genoud <redacted>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help