Re: [PATCH net-next 02/12] tipc: Add "max_ports" configuration parameter
From: David Miller <davem@davemloft.net>
Date: 2013-05-31 09:26:34
From: David Miller <davem@davemloft.net>
Date: 2013-05-31 09:26:34
From: Erik Hugne <redacted> Date: Fri, 31 May 2013 11:23:02 +0200
On Fri, May 31, 2013 at 01:40:28AM -0700, David Miller wrote:quoted
We never shrink the hash tables once we've grown them. That's a reasonable way to behave.Very well. Currently, the refs/portID's are built up of a random part, and an index part. The index is obtained by masking against the table size. If the table is allowed to grow, we must remove the random part from the portID. Otherwise we would index out a nonexistant or wrong port from a received packet.. But removing the random part would be a violation of the protocol spec, and potentially break interop between other implementations (like link selection..)
We allocate ports randomly for IPV4/IPV6 sockets, you can just fine too.