Thread (28 messages) 28 messages, 6 authors, 2013-06-04

Re: [PATCH net-next 02/12] tipc: Add "max_ports" configuration parameter

From: David Miller <davem@davemloft.net>
Date: 2013-05-31 08:29:23

From: Erik Hugne <redacted>
Date: Fri, 31 May 2013 10:25:38 +0200
On Thu, May 30, 2013 at 03:49:25PM -0700, David Miller wrote:
quoted
View compile time constants and module parameters as artificial
limits, they are terrible and unnecessary.

There is no reason you cannot restructure this table so that you
can dynamically size it at run time.
The TIPC ref table index is used directly as the port identity in the 
TIPC publications. When a socket is bound, this ID is published to all 
other nodes in the cluster.
If we where to allow the table to be changed dynamically, we would need
to change the port identities for already bound sockets/ports, withdraw
the old identity and publish the new one.
No you do not, simply grow the table just like we dynamically grow
hash tables in response to network/socket activity elsewhere in the
kernel.  You'll only allocate new indexes from the newly allocated
area, the existing indexes will remain the same.

I really will accept no excuses for this limitation, especially if
the response is an ugly module paramter.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help