On Thu, May 30, 2013 at 1:56 AM, Stephen Hemminger
[off-list ref] wrote:

On Wed, 29 May 2013 13:00:15 +0300
Mike Rapoport [off-list ref] wrote:

quoted

-/* Add/update destinations for multicast */
-static int vxlan_fdb_append(struct vxlan_fdb *f,
-                         __be32 ip, __be16 port, __u32 vni, __u32 ifindex)
+static int vxlan_rdst_append(struct vxlan_rdst *rdst, __be32 ip, __be16 port,
+                          __u32 vni, __u32 ifindex)
 {
      struct vxlan_rdst *rd_prev, *rd;

      rd_prev = NULL;
-     for (rd = &f->remote; rd; rd = rd->remote_next) {
+     for (rd = rdst; rd; rd = rd->remote_next) {

The remote destinations should be using one of our nice list macros.

Can you explain why?
Current linked list implementation for multiple destinations in fdb
seems quite Ok and I've just reused it for default destinations
management...

And what about locking? or RCU?

Oops, mu fault :)

--
Sincerely yours,
Mike.