Hi Sergei,

On 04/30/2013 01:54 PM, Sergei Shtylyov wrote:

Hello.

On 30-04-2013 11:33, Gerlando Falauto wrote:

quoted

Signed-off-by: Gerlando Falauto <redacted>
---
Changes from v2:
* Split cosmetic from functional changes

quoted

   net/tipc/bcast.c |   13 +++++++------
   1 file changed, 7 insertions(+), 6 deletions(-)

quoted

diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
index 2655c9f..8438e01 100644
--- a/net/tipc/bcast.c
+++ b/net/tipc/bcast.c

@@ -584,8 +584,7 @@ static int tipc_bcbearer_send(struct sk_buff *buf,
   {
   	int bp_index;

-	/*
-	 * Prepare broadcast link message for reliable transmission,
+	/* Prepare broadcast link message for reliable transmission,
   	 * if first time trying to send it;
   	 * preparation is skipped for broadcast link protocol messages
   	 * since they are sent in an unreliable manner and don't need it

@@ -613,11 +612,12 @@ static int tipc_bcbearer_send(struct sk_buff *buf,
   		struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary;

   		if (!p)
-			break;	/* no more bearers to try */
+			break; /* No more bearers to try */

-		tipc_nmap_diff(&bcbearer->remains, &p->nodes, &bcbearer->remains_new);
+		tipc_nmap_diff(&bcbearer->remains, &p->nodes,
+			       &bcbearer->remains_new);

     It apeears you nopt only cleaning up comments in this patch but you don't
mention this change in the changelog...

That's just adding a line break to split a long line.
Come on, seriously, is that *really* worth mentioning?
How about "tipc: cosmetic: clean up comments and break a long line"?

Thanks,
Gerlando