Re: [PATCH] ixp4xx_eth: set the device dma_coherent_mask

On 3/19/2013 10:03 PM, David Miller wrote:

From: Christophe Aeschlimann<redacted>
Date: Tue, 19 Mar 2013 16:59:25 +0100

quoted

quoted

Without the mask it is impossible to take the network interface up
since it returns the following error:

quoted

quoted

net eth1: coherent DMA mask is unset
ifconfig: SIOCSIFFLAGS: Cannot allocate memory

Tested on an out-of-tree ixp425 based board.

Signed-off-by: Christophe Aeschlimann<redacted>

  ...

quoted

quoted

@@ -1398,6 +1398,7 @@ static int eth_init_one(struct platform_device *pdev)
 		return -ENOMEM;
 
 	SET_NETDEV_DEV(dev, &pdev->dev);
+	dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);

Hmmm, shouldn't this be the default value, set by the bus layer or
similar?

bus layer or any platform code doesn't init this value. The same issue 
applies
to CPSW driver also. Previously the same was done in board or device 
file. But
this approach is obsolete now, need to think of how it can be resolved in DT
approach

Regards
Mugunthan V N