Thread (3 messages) flat view 3 messages, 3 authors, 2013-03-19

Re: [PATCH] ixp4xx_eth: set the device dma_coherent_mask

From: David Miller <davem@davemloft.net>
Date: 2013-03-19 16:34:01
Also in: lkml

From: Christophe Aeschlimann <redacted>
Date: Tue, 19 Mar 2013 16:59:25 +0100
Without the mask it is impossible to take the network interface up
since it returns the following error:
quoted
net eth1: coherent DMA mask is unset
ifconfig: SIOCSIFFLAGS: Cannot allocate memory
Tested on an out-of-tree ixp425 based board.

Signed-off-by: Christophe Aeschlimann <redacted>
 ...
quoted hunk ↗ jump to hunk
@@ -1398,6 +1398,7 @@ static int eth_init_one(struct platform_device *pdev)
 		return -ENOMEM;
 
 	SET_NETDEV_DEV(dev, &pdev->dev);
+	dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
Hmmm, shouldn't this be the default value, set by the bus layer or
similar?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help