Thread (5 messages) 5 messages, 3 authors, 2013-03-29

Re: [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward_skb'

From: David Miller <davem@davemloft.net>
Date: 2013-03-29 19:26:07

From: Eric Dumazet <redacted>
Date: Fri, 29 Mar 2013 12:17:36 -0700
On Fri, 2013-03-29 at 15:11 -0400, David Miller wrote:
quoted
From: Shmulik Ladkani <redacted>
Date: Thu, 28 Mar 2013 11:13:26 +0200
quoted
'nf_reset' is called just prior calling 'netif_rx'.
No need to call it twice.

Reported-by: Igor Michailov <redacted>
Signed-off-by: Shmulik Ladkani <redacted>
I do not see this happening in the:

	macvlan_start_xmit()

		 --> macvlan_queue_xmit()

code path.

I'm not applying this patch.  There seems to be no real agreement
that the caller of dev_forward_skb() takes care of the nf_reset().

And wouldn't it be better to consolidate the nf_reset() calls
into one place instead of several, increasing the audit burdon.
Hmm, I believe you misread this patch :

nf_reset() is called _twice_ in dev_forward_skb()
Aha, that makes more sense, applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help