Thread (5 messages) 5 messages, 3 authors, 2013-03-29

Re: [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward_skb'

From: Eric Dumazet <hidden>
Date: 2013-03-28 13:36:52

On Thu, 2013-03-28 at 11:13 +0200, Shmulik Ladkani wrote:
quoted hunk ↗ jump to hunk
'nf_reset' is called just prior calling 'netif_rx'.
No need to call it twice.

Reported-by: Igor Michailov <redacted>
Signed-off-by: Shmulik Ladkani <redacted>
---
 net/core/dev.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 2db88df..071f398 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1624,7 +1624,6 @@ int dev_forward_skb(struct net_device *dev, struct sk_buff *skb)
 	}
 
 	skb_orphan(skb);
-	nf_reset(skb);
 
 	if (unlikely(!is_skb_forwardable(dev, skb))) {
 		atomic_long_inc(&dev->rx_dropped);
Acked-by: Eric Dumazet <edumazet@google.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help