Sorry, my fault, your code is right.

-----Original Message-----
From: Hannes Frederic Sowa [mailto:hannes@stressinduktion.org]
Sent: Thursday, March 28, 2013 11:30 AM
To: Huang, Xiong
Cc: Sven Hartge; netdev@vger.kernel.org
Subject: Re: Atheros Communications Inc. AR8121/AR8113/AR8114 Gigabit or
Fast Ethernet (rev b0) 1.0.0.7 md5/sha1 corrupted using NFS and samba
(updated) Version 2

On Thu, Mar 28, 2013 at 03:25:29AM +0000, Huang, Xiong wrote:

quoted

Please don't revise following code:

			rx_page->read_offset +=
				(((u32)((prrs->word1 >>

RRS_PKT_SIZE_SHIFT) &

quoted

				RRS_PKT_SIZE_MASK) +
				sizeof(struct atl1e_recv_ret_status) + 31) &
						0xFFFFFFE0);

Here 32bytes alignment is no matter with Page alignment.

If I revert this change I get sequence errors:

[  781.449864] ATL1E 0000:04:00.0: irq 45 for MSI/MSI-X [  781.454634] IPv6:
ADDRCONF(NETDEV_UP): p33p1: link is not ready [  782.893744] ATL1E
0000:04:00.0 p33p1: NIC Link is Up <100 Mbps Full Duplex> [  782.893797] IPv6:
ADDRCONF(NETDEV_CHANGE): p33p1: link becomes ready [  783.194443]
ATL1E 0000:04:00.0 p33p1: rx sequence number error (rx=0) (expect=1)
[  783.204497] ATL1E 0000:04:00.0 p33p1: NIC Link is Up <100 Mbps Full Duplex>
[  783.225336] ATL1E 0000:04:00.0 p33p1: rx sequence number error (rx=0)
(expect=1) [  783.236636] ATL1E 0000:04:00.0 p33p1: NIC Link is Up <100 Mbps
Full Duplex> [  783.462652] ATL1E 0000:04:00.0 p33p1: rx sequence number
error (rx=0) (expect=1) [  783.472530] ATL1E 0000:04:00.0 p33p1: NIC Link is
Up <100 Mbps Full Duplex> [  784.038976] ATL1E 0000:04:00.0 p33p1: rx
sequence number error (rx=0) (expect=1) [  784.047354] ATL1E 0000:04:00.0
p33p1: NIC Link is Up <100 Mbps Full Duplex> ...