From: Ben Hutchings <redacted>
Date: Wed, 27 Mar 2013 18:12:33 +0000

On Wed, 2013-03-27 at 18:08 +0000, Colin Ian King wrote:

quoted

On 27/03/13 17:46, David Miller wrote:

quoted

From: Ben Hutchings <redacted>
Date: Wed, 27 Mar 2013 17:44:17 +0000

quoted

On Wed, 2013-03-27 at 11:19 +0000, Colin King wrote:

quoted

From: Colin Ian King <redacted>

yam_open checks if dev is null, however, before that check it
accesses some of the fields from dev in a proceeding printk which
will cause a null pointer dereference error if dev is nul. Move
the printk to after the null check.

This function will never be called with dev == NULL.

Then let's remove at least that part of the check.

Good point. How about the following..

quoted

From 564f111f196d9d7293e922a68ba973210d191129 Mon Sep 17 00:00:00 2001
From: Colin Ian King <redacted>
Date: Wed, 27 Mar 2013 13:59:05 -0400
Subject: [PATCH] yam: remove redundant null check on dev

yam_open has a redundant null check on null,  it will
never be called with dev == NULL. Remove this redundant check.
This also cleans up a smatch warning:

drivers/net/hamradio/yam.c:869 yam_open() warn: variable
  dereferenced before check 'dev' (see line 867)

Signed-off-by: Colin Ian King <redacted>

Reviewed-by: Ben Hutchings <redacted>

Colin, please formally resubmit this using a fresh mailing list
posting rather than as a reply in this thread.  Please incorporate
Ben's reviewed-by tag when doing so, thanks.