On 27/03/13 17:46, David Miller wrote:

From: Ben Hutchings <redacted>
Date: Wed, 27 Mar 2013 17:44:17 +0000

quoted

On Wed, 2013-03-27 at 11:19 +0000, Colin King wrote:

quoted

From: Colin Ian King <redacted>

yam_open checks if dev is null, however, before that check it
accesses some of the fields from dev in a proceeding printk which
will cause a null pointer dereference error if dev is nul. Move
the printk to after the null check.

This function will never be called with dev == NULL.

Then let's remove at least that part of the check.

Good point. How about the following..