Re: [PATCH 2/6] xen-netfront: reduce gso_max_size to account for ethernet header
From: Eric Dumazet <hidden>
Date: 2013-03-25 16:54:35
From: Eric Dumazet <hidden>
Date: 2013-03-25 16:54:35
On Mon, 2013-03-25 at 12:18 -0400, David Miller wrote:
This is effectively the default already, you don't need to change this
value explicitly.
->gso_max_size is set by default to 65536 and then TCP performs this
calculation:
xmit_size_goal = ((sk->sk_gso_max_size - 1) -
inet_csk(sk)->icsk_af_ops->net_header_len -
inet_csk(sk)->icsk_ext_hdr_len -
tp->tcp_header_len);
thereby making it adhere to your limits just fine.For locally generated TCP traffic this is the case. However, GRO can build packets up to 65535 bytes, not including the Ethernet header. For such packets, it seems xen-netfront needs a segmentation. And we might have other providers as well (UFO for example ?), but I have not checked.