Re: [PATCH] fec: Unify fec_ptp.c and fec.c
From: Uwe Kleine-König <hidden>
Date: 2013-03-21 10:09:55
Hello, On Thu, Mar 21, 2013 at 06:02:02PM +0800, Frank Li wrote:
quoted hunk ↗ jump to hunk
I suggest use below patch to fix this problem--- a/drivers/net/ethernet/freescale/Makefile +++ b/drivers/net/ethernet/freescale/Makefile@@ -2,7 +2,8 @@ # Makefile for the Freescale network device drivers. # -obj-$(CONFIG_FEC) += fec.o fec_ptp.o +obj-$(CONFIG_FEC) += fec_driver.o +fec_driver-objs := fec.o fec_ptp.o obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx.o ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y) obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o
I thought about suggesting something similar, too. I would have renamed fec.c to (say) fec_base.c and then kept the module name fec.ko. Not sure keeping the module name is critical. What is missing from your patch is dropping the EXPORT_SYMBOLs. Other than that I like it better than using a single .c file. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |