Re: SYSFS "errors"
From: Borislav Petkov <bp@alien8.de>
Date: 2013-02-19 14:50:53
Also in:
linux-pm, linux-scsi, lkml
Possibly related (same subject, not in this thread)
- 2013-02-19 · Re: SYSFS "errors" · Felipe Balbi <hidden>
On Tue, Feb 19, 2013 at 11:35:21AM -0300, Mauro Carvalho Chehab wrote:
That's covers everything but Hannes arguments. I don't think that adding just one more device_create_file() on a driver that creates dozens (or hundreds) of sys nodes, depending on the number of DIMMS on the system would make it any worse.
Right, those attributes are created once during EDAC core init and we haven't seen any issues so far so let's not address this just yet but make a mental note about the race condition possibility.
[PATCH EDAC] edac: only create sdram_scrub_rate where supported Currently, sdram_scrub_rate sysfs node is created even if the device doesn't support get/set the scub rate. Change the logic to only create this device node when the operation is supported. Reported-by: Felipe Balbi <redacted> Signed-off-by: Mauro Carvalho Chehab <redacted>
Acked-by: Borislav Petkov <redacted>
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--