Thread (32 messages) read the whole thread 32 messages, 6 authors, 2013-02-19

Re: SYSFS "errors"

From: Borislav Petkov <bp@alien8.de>
Date: 2013-02-18 22:44:12
Also in: linux-pm, linux-scsi, lkml

Possibly related (same subject, not in this thread)

On Mon, Feb 18, 2013 at 02:26:18PM -0800, Greg KH wrote:
I don't know, it depends on if userspace can handle this properly or
not. What tools rely on this sysfs file? WHat happens when they get a
non-number in the file?
I'm not aware of any, frankly speaking.

If there are any, those tools should be able to handle the -ENODEV
they get. Now, if this gets changed this way, the read would succeed
but they'll have to parse the returned value and see that it is not an
integer.

So I don't know either.

But my gut feeling says to stay concervative and not touch this code -
we don't know what uses it and how much we would break by "fixing" it.
The current situation is not that big of a deal IMVHO and I'd be willing
to accept the small inconcistency versus possibly breaking userspace.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help