Thread (7 messages) 7 messages, 4 authors, 2013-02-28

Re: [PATCH] bgmac: omit the fcs

From: David Miller <davem@davemloft.net>
Date: 2013-02-28 19:21:44

From: Rafał Miłecki <zajec5@gmail.com>
Date: Thu, 28 Feb 2013 18:57:03 +0100
2013/2/28 Hauke Mehrtens [off-list ref]:
quoted
Do not include the frame check sequence when adding the skb to
netif_receive_skb(). This causes problems when this interface was
bridged to a wifi ap and a big package should be forwarded from this
Ethernet driver through a bride to the wifi client.
Is this a real fix?

Don't get me wrong, but it sounds a little like a workaround for some
issue in another network layer ;)
FCS should never be included in the SKB unless a specific debugging
configuration knob has enabled it.

Having the FCS there will screw up things like device provided partial
checksums (CHECKSUM_PARTIAL), which operate over the entire contents
of the packet starting at a particular offset, so if the FCS is there
we'll include it.

This change is therefore about as correct as can possibly be.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help