Re: [PATCH] bgmac: omit the fcs
From: Hauke Mehrtens <hauke@hauke-m.de>
Date: 2013-02-28 18:13:44
On 02/28/2013 06:57 PM, Rafał Miłecki wrote:
2013/2/28 Hauke Mehrtens [off-list ref]:quoted
Do not include the frame check sequence when adding the skb to netif_receive_skb(). This causes problems when this interface was bridged to a wifi ap and a big package should be forwarded from this Ethernet driver through a bride to the wifi client.Is this a real fix? Don't get me wrong, but it sounds a little like a workaround for some issue in another network layer ;)
Many drivers are doing similar things, b44 is one of them. Hopefully someone more familiar with the network stack could say if this is the right way to do this. On a wireless client I saw that all packages directly from my router did not had a FCS, but all the packages send from an other LAN client which went through this driver had a FCS and where 4 bytes bigger and this FCS was wrong. Hauke