Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'
From: Arnd Bergmann <hidden>
Date: 2013-01-25 23:45:31
Also in:
linux-arm-kernel, linux-nfs, lkml
Subsystem:
kernel nfsd, sunrpc, and lockd servers, networking [general], nfs, sunrpc, and lockd clients, the rest · Maintainers:
Chuck Lever, Jeff Layton, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Trond Myklebust, Anna Schumaker, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2013-01-25 · [PATCH 15/19] sunrpc: don't warn for unused variable 'buf' · Arnd Bergmann <arnd@arndb.de>
On Friday 25 January 2013, Myklebust, Trond wrote:
quoted
-----Original Message----- From: Arnd Bergmann [mailto:arnd-r2nGTMty4D4@public.gmane.org] Marking it as __maybe_unused avoids a harmless gcc warning.Alternatively, just declare it using the RPC_IFDEBUG() macro.
Right, makes sense: that's more consistent with other functions doing the same thing. Thanks for taking a look. Arnd 8<----
From 3b2baeac061bd60dbf14bb61bcc03cbd64c85ac4 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <redacted> Date: Mon, 26 Nov 2012 22:46:26 +0000 Subject: [PATCH] sunrpc: don't warn for unused variable 'buf' When RPC_DEBUG is unset, the dprintk() macro does nothing, causing the 'buf' variable in svc_printk to become unused. Enclosing it in RPC_IFDEBUG avoids a harmless gcc warning. Without this patch, building at91_dt_defconfig results in: net/sunrpc/svc.c: In function 'svc_printk': net/sunrpc/svc.c:1051:7: warning: unused variable 'buf' [-Wunused-variable] Signed-off-by: Arnd Bergmann <redacted> Cc: "J. Bruce Fields" <redacted> Cc: Trond Myklebust <redacted> Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index dbf12ac..9485e66 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c@@ -1047,7 +1047,7 @@ void svc_printk(struct svc_rqst *rqstp, const char *fmt, ...) { struct va_format vaf; va_list args; - char buf[RPC_MAX_ADDRBUFLEN]; + RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]); va_start(args, fmt); --
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html