[PATCH net-next rfc 1/2] tuntap: forbid calling TUNSETQUEUE for a persistent device with no queues
From: Jason Wang <hidden>
Date: 2012-12-11 11:11:52
Also in:
lkml
Subsystem:
networking drivers, the rest, tun/tap driver · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds, Willem de Bruijn, Jason Wang
When re-establish to a persistent deivce wihout queues attached, TUNSETIFF should be called instead of TUNSETQUEUE to do the proper permission checking. Signed-off-by: Jason Wang <redacted> --- drivers/net/tun.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 14a0454..d593f56 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c@@ -1771,6 +1771,9 @@ static int tun_set_queue(struct file *file, struct ifreq *ifr) ret = -EINVAL; else if (tun_not_capable(tun)) ret = -EPERM; + /* TUNSETIFF is needed to do permission checking */ + else if (tun->numqueues == 0) + ret = -EPERM; else ret = tun_attach(tun, file); } else if (ifr->ifr_flags & IFF_DETACH_QUEUE)
--
1.7.1