Re: [PATCH] fix initializer entry defined twice issue

On 12/06/2012 06:05 PM, Cong Ding wrote:

On Thu, Dec 06, 2012 at 05:59:21PM -0600, Patrick Trantham wrote:

quoted

On 12/06/2012 05:16 PM, Cong Ding wrote:

quoted

the ".config_intr" is defined twice in both line 208 and 212.

Signed-off-by: Cong Ding <redacted>
---
  drivers/net/phy/smsc.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index 16dceed..5cee6bd 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c

@@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
  	/* basic functions */
  	.config_aneg	= genphy_config_aneg,
  	.read_status	= lan87xx_read_status,
-	.config_intr	= smsc_phy_config_intr,
  	/* IRQ related */
  	.ack_interrupt	= smsc_phy_ack_interrupt,

Hi Cong,

That looks like a mistake from my previous patch to that file.  Copy
and paste fail.

The line should read:
.config_init    = smsc_phy_config_init,

I can submit a patch once I get off work unless you beat me to it.

Thanks for the note. It's better that you submit a patch together with your
code.

- cong

Patch submitted, thanks for pointing this out!

- Patrick