Thread (4 messages) flat view 4 messages, 2 authors, 2012-12-07

Re: [PATCH] fix initializer entry defined twice issue

From: Patrick Trantham <hidden>
Date: 2012-12-07 00:25:19
Also in: lkml

On 12/06/2012 05:16 PM, Cong Ding wrote:
quoted hunk ↗ jump to hunk
the ".config_intr" is defined twice in both line 208 and 212.

Signed-off-by: Cong Ding <redacted>
---
  drivers/net/phy/smsc.c |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
index 16dceed..5cee6bd 100644
--- a/drivers/net/phy/smsc.c
+++ b/drivers/net/phy/smsc.c
@@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = {
  	/* basic functions */
  	.config_aneg	= genphy_config_aneg,
  	.read_status	= lan87xx_read_status,
-	.config_intr	= smsc_phy_config_intr,
  
  	/* IRQ related */
  	.ack_interrupt	= smsc_phy_ack_interrupt,
Hi Cong,

That looks like a mistake from my previous patch to that file.  Copy and 
paste fail.

The line should read:
.config_init    = smsc_phy_config_init,

I can submit a patch once I get off work unless you beat me to it.

regards,
Patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help