Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

On Monday, December 03, 2012 01:18:48 PM Michael S. Tsirkin wrote:

On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote:

quoted

quoted

quoted

+

+ /* Work struct for refilling if we run low on memory. */

+ struct delayed_work refill;

I can't really see the justificaiton for a refill per queue. Just have

one work iterate all the queues if it happens, unless it happens often

(in which case, we need to look harder at this anyway).

But during this kind of iteration, we may need enable/disable the napi
regardless of whether the receive queue has lots to be refilled. This may
add extra latency.

We are running from the timer, so latency is not a concern I think.

Maybe, anyway it's only called when avaiable memory is low, so it should not 
be an issue.