Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

From
Michael S. Tsirkin <mst@redhat.com>
Date
2012-12-03 11:16:12
Also in
kvm, lkml, virtualization
Reply to
Jason Wang, 2012-12-03
On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote:
quoted
quoted
+
quoted
quoted
+ /* Work struct for refilling if we run low on memory. */
quoted
quoted
+ struct delayed_work refill;
quoted
quoted
I can't really see the justificaiton for a refill per queue. Just have
quoted
one work iterate all the queues if it happens, unless it happens often
quoted
(in which case, we need to look harder at this anyway).
 

But during this kind of iteration, we may need enable/disable the napi
regardless of whether the receive queue has lots to be refilled. This may add
extra latency.
We are running from the timer, so latency is not a concern I think.

-- 
MST
Thread (27 messages) 27 messages, 4 authors, last reply 2012-12-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help