Re: [PATCH] build: unbreak linkage of m_xt.so
From: Mike Frysinger <hidden>
Date: 2012-12-16 22:02:22
Also in:
netfilter-devel
On Saturday 15 December 2012 19:32:48 Jan Engelhardt wrote:
quoted hunk ↗ jump to hunk
--- a/configure +++ b/configure@@ -4,7 +4,6 @@ INCLUDE=${1:-"$PWD/include"} : ${PKG_CONFIG:=pkg-config} : ${CC=gcc} -echo "PKG_CONFIG:=${PKG_CONFIG}" >>Config # Make a temp directory in build tree. TMPDIR=$(mktemp -d config.XXXXXX)@@ -224,6 +223,7 @@ rm -f $TMPDIR/ipsettest.c $TMPDIR/ipsettest } echo "# Generated config based on" $INCLUDE >Config +echo "PKG_CONFIG:=${PKG_CONFIG}" >>Config echo "TC schedulers"
the use of un-indented shell functions makes the code read in a way it doesn't actually execute. i'd suggest moving this logic into a function to match existing style rather than simply moving the Config write. i'll post a patch. -mike
Attachments
- signature.asc [application/pgp-signature] 836 bytes