Re: [PATCH] build: unbreak linkage of m_xt.so

On Sunday 2012-12-16 18:03, Jamal Hadi Salim wrote:

On 12-12-16 05:30 AM, Jamal Hadi Salim wrote:

quoted

I can confirm it builds fine for me now if i take out the hack I had and
use this patch.

Sorry, I take what i said back and went back to explicitly adding -l xtables.
The problem is still the intepretation of tc/Makefile. Here's the compile
output.
----
gcc -Wall -Wstrict-prototypes -O2 -I../include -DRESOLVE_HOSTNAMES
-DLIBDIR=\"/usr/lib\" -DCONFDIR=\"/etc/iproute2\" -D_GNU_SOURCE -DCONFIG_GACT
-DCONFIG_GACT_PROB -DIPT_LIB_DIR=\"/lib/xtables\" -DYY_NO_INPUT
-Wl,-export-dynamic -shared -fpic -o m_xt.so m_xt.c $(pkg-config xtables
--cflags --libs)
----

I saw the same during make, _but_, on running `ldd tc/m_xt.so`, I got a
libxtables.so entry, so I thought I was fine.



"$() "is something for the shell to expand, not make. See this testcase.

$ make
echo $(pkg-config xtables --cflags --libs)
-I/usr/include/iptables-1.4.16.3 -lxtables
$ cat Makefile 
a:
        echo $$(pkg-config xtables --cflags --libs)