Thread (6 messages) flat view 6 messages, 3 authors, 2012-12-16

Re: [PATCH] Fix comment for packets without data

From: Rick Jones <hidden>
Date: 2012-12-14 21:28:54
Also in: netfilter-devel

On 12/14/2012 02:53 AM, Florent Fourcot wrote:
quoted hunk ↗ jump to hunk
Remove ambiguity of double negation

Signed-off-by: Florent Fourcot <redacted>
---
  net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
index 00ee17c..137e245 100644
--- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
+++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
@@ -81,8 +81,8 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff,
  	}
  	protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off);
  	/*
-	 * (protoff == skb->len) mean that the packet doesn't have no data
-	 * except of IPv6 & ext headers. but it's tracked anyway. - YK
+	 * (protoff == skb->len) means the packet has not data, just
+	 * IPv6 and possibly extensions headers, but it is tracked anyway
  	 */
  	if (protoff < 0 || (frag_off & htons(~0x7)) != 0) {
  		pr_debug("ip6_conntrack_core: can't find proto in pkt\n");
Acked-by: Rick Jones <redacted>

rick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help