Thread (8 messages) flat view 8 messages, 4 authors, 2012-12-14

Re: [PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect

From: Joe Perches <joe@perches.com>
Date: 2012-12-13 19:37:13

On Thu, 2012-12-13 at 12:59 -0500, David Miller wrote:
quoted
+     hdr = (u8 *)ndopts.nd_opts_rh;
(u8 *)[SPACE]ndopts...
Really?

checkpatch bleats a --strict message:

CHECK: No space is necessary after a cast
#5: FILE: t.c:5:
+
+	bar = *(int *) foo;

It's 2/1 no space v space in drivers/net and net.


$ git grep -E "\*\) " drivers/net net | wc -l
4293
$ git grep -E "\*\)[^ ;]" drivers/net net | wc -l
8261

There are many false positives in the first case,
not too many for the second.

I was a bit surprised about how many of the
first case existed.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help