[PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect · Duan Jiong <hidden> · 2012-12-13
Re: [PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect · David Miller <davem@davemloft.net> · 2012-12-13
Re: [PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect · Joe Perches <joe@perches.com> · 2012-12-13
Re: [PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect · David Miller <davem@davemloft.net> · 2012-12-13
[PATCH] ndisc: Use more standard logging styles · Joe Perches <joe@perches.com> · 2012-12-14
Re: [PATCH] ndisc: Use more standard logging styles · Joe Perches <joe@perches.com> · 2012-12-14
[PATCH V2] ndisc: Use more standard logging styles · Joe Perches <joe@perches.com> · 2012-12-14
Re: [PATCH V2] ndisc: Use more standard logging styles · Eric Dumazet <hidden> · 2012-12-14

Re: [PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect

From: David Miller <davem@davemloft.net>
Date: 2012-12-13 17:59:16

From: Duan Jiong <redacted>
Date: Thu, 13 Dec 2012 19:21:37 +0800

+	if (!ndisc_parse_options(msg->opt, ndoptlen, &ndopts)) {
+		ND_PRINTK(2, warn,
+			  "Redirect: invalid ND options\n");

Do not add more uses of such baroque kernel logging mechanisms.

+	if (!ndopts.nd_opts_rh) {
+		return;
+	}

Single statement basic blocks should never be surrounded by
curly braces, they just waste lines.

+	hdr = (u8 *)ndopts.nd_opts_rh;

(u8 *)[SPACE]ndopts...

+	if(!pskb_pull(skb, hdr - skb_transport_header(skb))) {

if[SPACE](...