RE: [net-next 1/7] bna: Code Cleanup and Enhancements

From: David Miller [mailto:davem@davemloft.net]
Sent: Monday, December 10, 2012 2:14 PM

From: Rasesh Mody <redacted>
Date: Mon, 10 Dec 2012 13:41:59 -0800

quoted

-		skb = unmap_array[unmap_cons].skb;
-		BUG_ON(!(skb));
-		unmap_array[unmap_cons].skb = NULL;
+		curr_ua = &unmap_array[unmap_cons];
+
+		skb = curr_ua->skb;
+		BUG_ON(!(skb));\

                              ^^^

Really?

Please carefully review your own work before submitting it for
inclusion.  When you have erroneous things like this in the very first
patch it reflects very poorly upon the quality of your work.

Sorry Dave, it accidentally got introduced. I will rectify it and resend the patches after carefully reviewing patches for similar errors.

Thanks
Rasesh